Fix four small papercuts #2149
Merged
Fix four small papercuts #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test does not correctly test the "only existing" behavior (and only functions because of a typo in the test), fix that by moving it to before the fallback test (where it needs to be) and correctly setting up the existing names map Also, added some comments to make what is being tested more clear Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
Code Coverage DiffThis PR does not change the code coverage |
|
/retest |
torredil
approved these changes
Sep 18, 2024
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@ElijahQuinones: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
AndrewSirenko
approved these changes
Sep 19, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix, mostly
What is this PR about? / Why do we need it?
Fixes four small papercuts:
Cleanup TestNameAllocatorLikelyBadName to prevent code coverage flapping
This should prevent code coverage constantly flapping on this test by properly setting up the
existingNamesmap. Also, added some comments to make the test more clear.Adjust TestExpiringCache timeouts to decrease CI flakes
This test flakes all the time in CI, especially on the Windows unit tests. I bumped up the sleeps to hopefully combat this, it's set to run in parallel so shouldn't make a significant difference to overall test time.
Standardize deployment methods by removing Kustomize-specific changes
Our helm chart contains two places that are used to magically inject comments into the Kustomize deployment. Remove these to standardize the chart and because they're bad:
In
controller.yaml, the Kustomize deployment comments out the mode by default, thus running the driver inAllmode and running the node server on the controller. This is pointless, wastes RAM and CPU, and increases the attack surface.In
serviceaccount-csi-controller.yaml, the Kustomize deployment has a comment about IRSA. Documenting via comments in the manifests is a horrible practice, EKS Pod Identity is superior to and largely replaces IRSA, and the EKS docs already appropriately document how to use IRSA.Set PATH for kubetest2 so it can find helpers
kubetest2isn't properly pinned unless its path points to where the helper binaries are installed, as it shells out to the helpers directly. Without this fixkubetest2must be installed locally and the E2E tests will use the local version instead of the pinned version for half the functionality.What testing is done?
CI/Manual